[webkit-reviews] review denied: [Bug 83547] Clean up CSSParser::parseFillRepeat(). : [Attachment 136395] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 83547: Clean up CSSParser::parseFillRepeat().
https://bugs.webkit.org/show_bug.cgi?id=83547

Attachment 136395: Patch
https://bugs.webkit.org/attachment.cgi?id=136395&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136395&action=review


> Source/WebCore/css/CSSParser.cpp:3306
> +
> +    // If only one value was specified, value2 is the same as value1.
> +    m_implicitShorthand = true;
> +    value2 =
cssValuePool().createIdentifierValue(static_cast<CSSPrimitiveValue*>(value1.get
())->getIdent());

Shouldn't this code be inside the else block of 'if (id == CSSValueRepeat ||
...) { .... } else { /* here! */ }'?