[webkit-reviews] review granted: [Bug 83478] Web Inspector: annotate front-end for newer closure compiler. : [Attachment 136238] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 83478: Web Inspector: annotate front-end for newer closure compiler.
https://bugs.webkit.org/show_bug.cgi?id=83478

Attachment 136238: Patch
https://bugs.webkit.org/attachment.cgi?id=136238&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136238&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:274
>	    * @param {Array.<DebuggerAgent.Location>} locations

locations param is also be optional/nullable, isn't it?

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:469
> +	* @param {number=} fromIndex // must declare optional

Could you provide more derailed comment or remove this one as it doesn't
doesn't add much information?

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:548
> +	* @param {number=} fromIndex // must declare optional

Same here.