[webkit-reviews] review granted: [Bug 83528] Add setJSWrapperForActiveDOMNode and use it for Nodes that are also ActiveDOMObjects : [Attachment 136348] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Adam Klein
<adamk at chromium.org>'s request for review:
Bug 83528: Add setJSWrapperForActiveDOMNode and use it for Nodes that are also
ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=83528

Attachment 136348: Patch
https://bugs.webkit.org/attachment.cgi?id=136348&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136348&action=review


>> Source/WebCore/ChangeLog:15
>> +	    No new tests, no change in behavior.
> 
> Recently we've observed several changes in code generators around Nodes.
Shall we add WebCore/bindings/scripts/test/TestNode.idl, so that we can test
the generated code for Nodes?

Although I think it is basically a good idea to add TestNode.idl, but this
patch requires a test case for an Active Node, which is an edge case. If we add
a new test interface for these edge cases one by one, the number of Test*.idl
will increase. Thus, it might be OK not to add a test case for this patch.
(It's up to you.)