[webkit-reviews] review granted: [Bug 83538] Don't let CSSPropertyWebkitPerspective dereference primitiveValue without null check. : [Attachment 136373] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 83538: Don't let CSSPropertyWebkitPerspective dereference primitiveValue
without null check.
https://bugs.webkit.org/show_bug.cgi?id=83538

Attachment 136373: Patch
https://bugs.webkit.org/attachment.cgi?id=136373&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136373&action=review


> Source/WebCore/ChangeLog:12
> +	   Coverity pointed out that we potentially dereference primitiveValue
here without checking for null.
> +	   I've added an early out for that case to make sure it can't ever
happen. I don't know if it's actually
> +	   possible to exercise that code path or not - probably the parser
prevents it from being hit in practice.

Have you tried writing a test?