[webkit-reviews] review canceled: [Bug 82262] [chromium] Replicas should be included in the computed occlusion : [Attachment 136376] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 19:32:57 PDT 2012


Dana Jansens <danakj at chromium.org> has canceled Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 82262: [chromium] Replicas should be included in the computed occlusion
https://bugs.webkit.org/show_bug.cgi?id=82262

Attachment 136376: Patch
https://bugs.webkit.org/attachment.cgi?id=136376&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136376&action=review


> Source/WebCore/platform/graphics/chromium/cc/CCOcclusionTracker.cpp:129
> +	   transformedRegion.unite(intersection(surface->clipRect(),
enclosedIntRect(transform.mapRect(FloatRect(rects[i])))));

Oh this is wrong, need to check clipRect().isEmpty() first for a surface.


More information about the webkit-reviews mailing list