[webkit-reviews] review canceled: [Bug 83527] Reorder stringProtoFuncSplit() operations to share more code and avoid branches : [Attachment 136347] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has canceled  review:
Bug 83527: Reorder stringProtoFuncSplit() operations to share more code and
avoid branches
https://bugs.webkit.org/show_bug.cgi?id=83527

Attachment 136347: Patch
https://bugs.webkit.org/attachment.cgi?id=136347&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Aaarg, this is actually incorrect :(.
In the spec (8) says "If separator is a RegExp object (its [[Class]] is
"RegExp"), let R = separator; otherwise let R = ToString(separator)."

This was just not explicit in the code, but the tests cover that case.