[webkit-reviews] review denied: [Bug 82476] Extra display logic for the media control panel element : [Attachment 136293] Updated test expected output

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Victor Carbune
<vcarbune at adobe.com>'s request for review:
Bug 82476: Extra display logic for the media control panel element
https://bugs.webkit.org/show_bug.cgi?id=82476

Attachment 136293: Updated test expected output
https://bugs.webkit.org/attachment.cgi?id=136293&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136293&action=review


I'm r-ing this patch because it doesn't have a properly formatted change log
entry. In particular, it's missing a "Reviewed by" line in the
WebCore/ChangeLog file.

> Source/WebCore/ChangeLog:7
> +	   This patch fixes a bug which caused the controls to be displayed
> +	   when they should remain hidden. Added an extra variable to the
> +	   panel elements which properly keeps the state of the panel (visible
or not).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=82476

This change log entry doesn't conform to the format we use for change log
entries. In particular, it's missing a bug title and a "Reviewed by" line. The
top portion of a change log entry has the following lines (in order):
data/author's full name/author's email address, bug title, bug URL, Reviewed by
line, and change description. See
<http://www.webkit.org/coding/contributing.html#changelogs> for more details,
which references an example entry. Another example of a change log entry that
conforms to the aforementioned format is
<http://trac.webkit.org/changeset/103692/trunk/Source/WebCore/ChangeLog>.

> LayoutTests/ChangeLog:8
> +	   Added test to ensure that controls are not displayed when
> +	   the controls attribute is not set.
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=82476
> +
> +	   Reviewed by NOBODY (OOPS!).

Similarly, this change log entry doesn't conform to the format we use for a
change log entry.