[webkit-reviews] review granted: [Bug 74553] WebAudio: propagate a silence hint through the AudioNode graph. : [Attachment 136331] Patch

[bugzilla-daemon at webkit.org]

Chris Rogers <crogers at google.com> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 74553: WebAudio: propagate a silence hint through the AudioNode graph.
https://bugs.webkit.org/show_bug.cgi?id=74553

Attachment 136331: Patch
https://bugs.webkit.org/attachment.cgi?id=136331&action=review

------- Additional Comments from Chris Rogers <crogers at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136331&action=review


Thanks Jer, nice optimizations!  I have just one comment which you can address
before landing.  Or re-upload a new patch as you wish.

> Source/WebCore/Modules/webaudio/AudioNode.cpp:183
> +

Can we call inputsAreSilent() just one time and cache in a local bool to avoid
calling it twice in a row as an optimization?