[webkit-reviews] review granted: [Bug 83241] [chromium] Draw missing layer tile checkerboards as checkerboards : [Attachment 135931] Only checkerboard root, rename usedCheckerboard

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 83241: [chromium] Draw missing layer tile checkerboards as checkerboards
https://bugs.webkit.org/show_bug.cgi?id=83241

Attachment 135931: Only checkerboard root, rename usedCheckerboard
https://bugs.webkit.org/attachment.cgi?id=135931&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135931&action=review


Looks great. R=me

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:502
> +    EXECUTE_AND_VERIFY_SET_NEEDS_COMMIT_BEHAVIOR(0,
testLayer->setDrawCheckerboardForMissingTiles(!testLayer->drawCheckerboardForMi
ssingTiles()));

Changing this might change how the layer draws, so it probably _should_ trigger
needsDisplay / needsCommit (although in practice this won't matter since it's
effectively static state)