[webkit-reviews] review granted: [Bug 83504] [chromium] Replica layers are not drawn, so should not be painted : [Attachment 136300] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 14:23:21 PDT 2012

James Robinson <jamesr at chromium.org> has granted Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 83504: [chromium] Replica layers are not drawn, so should not be painted

Attachment 136300: Patch

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136300&action=review

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:531
> +	   LayerChromium* maskLayer = replicaLayer->maskLayer();

this shadows the earlier local which is a bit weird (and I wouldn't be
surprised if triggered a warning on some pedantic compiler somewhere). Can you:

*) reuse the local
*) pick another name
*) refactor shared code into a helper so we don't have to duplicate this block?

More information about the webkit-reviews mailing list