[webkit-reviews] review denied: [Bug 83491] Prepare html classes for sub-pixel LayoutUnits : [Attachment 136279] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 13:21:29 PDT 2012

Levi Weintraub <leviw at chromium.org> has denied Levi Weintraub
<leviw at chromium.org>'s request for review:
Bug 83491: Prepare html classes for sub-pixel LayoutUnits

Attachment 136279: Patch

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136279&action=review

>> Source/WebCore/html/ValidationMessage.cpp:123
>> +	bubble->setInlineStyleProperty(CSSPropertyTop, hostY +
static_cast<double>(hostRect.height()), CSSPrimitiveValue::CSS_PX);
> Why the double casts?

You're right, this can be removed. We were just missing a double flavor of
operator+ in FractionalLayoutUnit. Will upload again.

More information about the webkit-reviews mailing list