[webkit-reviews] review denied: [Bug 82971] Add Encrypted Media Extensions methods to HTMLMediaElement : [Attachment 135355] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied David Dorwin <ddorwin at chromium.org>'s
request for review:
Bug 82971: Add Encrypted Media Extensions methods to HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=82971

Attachment 135355: Patch
https://bugs.webkit.org/attachment.cgi?id=135355&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135355&action=review


This patch looks pretty good.  A few minor comments below.

> Source/WebCore/ChangeLog:10
> +	   Add Encrypted Media Extensions methods to HTMLMediaElement
> +	   https://bugs.webkit.org/show_bug.cgi?id=82971
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Tests: media/encrypted-media/encrypted-media-not-loaded.html
> +		  media/encrypted-media/encrypted-media-syntax.html
> +

Please add some more information to the ChangeLog.  For example, you might
mention the ENABLE(ENCRYPTED_MEDIA) macro and reference the spec that you're
implementing.

> Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h:210
> +    static bool webkitEncryptedMediaEnabled() { return
isEncryptedMediaEnabled; }
> +    static void setWebkitEncryptedMediaEnabled(bool isEnabled) {
isEncryptedMediaEnabled = isEnabled; }

We can drop the "webkit" prefix here.  (I know other features use the "webkit"
prefix, but they shouldn't.)

> Source/WebCore/html/HTMLMediaElement.cpp:2241
> +ExceptionCode
exceptionCodeForMediaKeyException(MediaPlayer::MediaKeyException exception)

Please mark this function as "static" so that it has internal linkage.	Also,
we tend to put functions like this near the top of the file.

> Source/WebCore/html/HTMLMediaElement.cpp:2252
> +    default:
> +	   ASSERT_NOT_REACHED();
> +	   return INVALID_STATE_ERR;

WebKit tends to leave off the "default" case so that the compiler complains if
we forget an enum value.

> Source/WebCore/html/HTMLMediaElement.cpp:2270
> +    if (initData.get()) {

There's no need to call ".get()" here.	There's an implicit conversion to bool.


> Source/WebCore/html/HTMLMediaElement.cpp:2303
> +    if (initData.get()) {

ditto

> Source/WebCore/html/HTMLMediaElement.cpp:2387
> -    
> +

Generally, we don't like to trim trailing whitespace on unrelated lines because
it messes up "svn blame".  Would you be willing to remove these parts of the
patch?

> Source/WebCore/html/HTMLMediaElement.idl:130
> +

This change seems unrelated.

> LayoutTests/platform/mac/Skipped:480
> +fast/events/constructors/media-key-event-constructor.html

I don't see this test in this patch...	Maybe it's in a later patch?