[webkit-reviews] review granted: [Bug 71541] Unnecessary scroll bar after changing the dimensions of a DIV : [Attachment 136186] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted SravanKumar S(:sravan)
<ssandela at innominds.com>'s request for review:
Bug 71541: Unnecessary scroll bar after changing the dimensions of a DIV
https://bugs.webkit.org/show_bug.cgi?id=71541

Attachment 136186: Patch
https://bugs.webkit.org/attachment.cgi?id=136186&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136186&action=review


> Source/WebCore/ChangeLog:9
> +	   or style application / selection scenarios will blindly exclude
previous scrollbars while computing overflow.

just keep during style change, style application / selection are synonyms here
:)

> Source/WebCore/rendering/RenderBox.h:218
> +    int pixelSnappedPaddingBoxWidth() const { return
snapSizeToPixel(paddingBoxWidth(), paddingLeft()); }
> +    int pixelSnappedPaddingBoxHeight() const { return
snapSizeToPixel(paddingBoxHeight(), paddingTop()); }

After checking with leviw, those offsets should be x() + borderLeft() and y() +
borderTop(). The existing code follows the same pattern but is wrong.

> LayoutTests/fast/overflow/overflow-auto-destroy-scroll-after-resizing.html:12

> +		   // There should be no scrollbars now
> +		   if (window.layoutTestController)
> +		       layoutTestController.notifyDone();

This should be removed.