[webkit-reviews] review granted: [Bug 75903] matchMedia() MediaQueryList not updating : [Attachment 134698] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 9 09:24:06 PDT 2012

Antti Koivisto <koivisto at iki.fi> has granted Luiz Agostini <luiz at webkit.org>'s
request for review:
Bug 75903: matchMedia() MediaQueryList not updating

Attachment 134698: patch

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=134698&action=review

> Source/WebCore/dom/Document.cpp:3121
> +void Document::evaluateMediaQueries()
> +{
> +    if (m_mediaQueryMatcher)
> +	   m_mediaQueryMatcher->styleSelectorChanged();
> +}

evaluateMediaQueries() is not a great name here as it gives impression that all
media queries are evaluated. Something like evaluateMediaQueryList would be
better. (MediaQueryMatcher:: styleSelectorChanged() makes no sense either)

More information about the webkit-reviews mailing list