[webkit-reviews] review canceled: [Bug 83347] webkit-patch: add a print-expectations command : [Attachment 136114] updated per review feedback

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has canceled Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 83347: webkit-patch: add a print-expectations command
https://bugs.webkit.org/show_bug.cgi?id=83347

Attachment 136114: updated per review feedback
https://bugs.webkit.org/attachment.cgi?id=136114&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136114&action=review


This looks a lot better, thanks.

> Tools/Scripts/webkitpy/tool/commands/queries.py:410
> +    TYPES = set(x.upper() for x in (TestExpectations.EXPECTATIONS.keys() +
TestExpectations.MODIFIERS.keys())).difference(set(['NONE']))

Can we evaluate this expression at a different time?  This will run every time
webkit-patch starts up.  For example, we could make this a @memoized class
function.  Actually, is this even used anywhere?

> Tools/Scripts/webkitpy/tool/commands/queries.py:420
> +		make_option('-i', '--include-keyword', action='append',
default=[],

bad indent