[webkit-reviews] review granted: [Bug 83284] [chromium] Add support for Battery Status API : [Attachment 136183] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted sadrul at chromium.org's request for
review:
Bug 83284: [chromium] Add support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=83284

Attachment 136183: Patch
https://bugs.webkit.org/attachment.cgi?id=136183&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136183&action=review


> Source/WebCore/Modules/battery/BatteryController.cpp:83
> +    m_batteryStatus = status;

status.release()

See http://www.webkit.org/coding/RefPtr.html if you're unsure why.

> Source/WebKit/chromium/public/WebView.h:458
> +    // Battery status API support
-------------------------------------------

I think we usually have a blank line after these section dividers.

> Source/WebKit/chromium/public/WebView.h:459
> +    virtual void updateBatteryStatus(const WebBatteryStatus&) { }

Can you add a comment about what this function does?