[webkit-reviews] review denied: [Bug 83465] Web Inspector: split nodes and edges array in heap profiler serialization. : [Attachment 136214] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied alexeif at chromium.org's request
for review:
Bug 83465: Web Inspector: split nodes and edges array in heap profiler
serialization.
https://bugs.webkit.org/show_bug.cgi?id=83465

Attachment 136214: Patch
https://bugs.webkit.org/attachment.cgi?id=136214&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136214&action=review


Pleas add a test for the new snapshot format, r- for this.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:184
> +		   this._array.push(0);

Can you move the meta node out of the array into its own element?

> Source/WebCore/inspector/front-end/HeapSnapshot.js:222
> +	       // Add an extra node that points at the end of edges array.

Can you do this is a separate change?