[webkit-reviews] review granted: [Bug 83390] Web Inspector: CodeGeneratorInspector.py: do not expose raw methods from generated types : [Attachment 136075] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Peter Rybin
<prybin at chromium.org>'s request for review:
Bug 83390: Web Inspector: CodeGeneratorInspector.py: do not expose raw methods
from generated types
https://bugs.webkit.org/show_bug.cgi?id=83390

Attachment 136075: Patch
https://bugs.webkit.org/attachment.cgi?id=136075&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136075&action=review


> Source/WebCore/ChangeLog:9
> +	   protected. InspectorObject and InspectorArray are reimplemented by
"public Morozov" pattern.

This pattern doesn't seem to be used outside of post-Soviet countries, could
you rephrase it?

> Source/WebCore/inspector/InspectorValues.cpp:671
> +    *output = reinterpret_cast<InspectorObject*>(this);

Why not static_cast as in other places?

> Source/WebCore/inspector/InspectorValues.cpp:683
> +    return reinterpret_cast<InspectorObject*>(this);

Same here and below.