[webkit-reviews] review denied: [Bug 82010] [Shadow DOM] InsertionPoint should have isActive() member function. : [Attachment 135751] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Takashi Sakamoto
<tasak at google.com>'s request for review:
Bug 82010: [Shadow DOM] InsertionPoint should have isActive() member function.
https://bugs.webkit.org/show_bug.cgi?id=82010

Attachment 135751: Patch
https://bugs.webkit.org/attachment.cgi?id=135751&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135751&action=review


> Source/WebCore/ChangeLog:3
> +	   [Shadow DOM] InsertionPoint should have isActive() member function.

This change doesn't look just adding a member function. It also affects the
behavior.
Could you reflect that fact in this summary?

Also for the record, could you have a link to the spec in the changelog?

> Source/WebCore/html/shadow/InsertionPoint.cpp:51
> +    if (isShadowBoundary() && isActive()) {

My feeling is that isShadowBoundary() should contains isActive() since inactive
node cannot be a boundary.