[webkit-reviews] review denied: [Bug 14959] No back forward entry added for pages created in javascript : [Attachment 136129] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 14959: No back forward entry added for pages created in javascript
https://bugs.webkit.org/show_bug.cgi?id=14959

Attachment 136129: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=136129&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136129&action=review


This patch has many serious problems.  As I wrote in Comment #29: If you're
interested in contributing to WebKit, you might want to start with an easier
bug.  This one pretty tricky.

> Source/WebCore/loader/HistoryController.cpp:890
> +    KURL generatedURL(ParsedURLString, "webkitgenerated:" + url);

What is the "webkitgenerated" scheme?  That looks like something you just made
up.