[webkit-reviews] review granted: [Bug 83426] Don't expose internal CSSValues in API : [Attachment 136137] try to fix build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 7 14:13:10 PDT 2012

Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 83426: Don't expose internal CSSValues in API

Attachment 136137: try to fix build

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136137&action=review

Very cool. r=me.
(Though you'll need to do something about the win failure.)

> Source/WebCore/css/CSSImageSetValue.cpp:146
> +    // Non-CSSValueList data is not accesible through CSS OM, no need to

Typo accessible.

> Source/WebCore/css/CSSValue.h:38
> +// Please don't expose more CSSValue types to the web.

Hear hear. Perhaps we could even get rid of WebKitCSSTransformValue.idl and

> Source/WebCore/css/RGBColor.cpp:42
> +    // Unique instances are safe.

Don't think this comment is needed.

More information about the webkit-reviews mailing list