[webkit-reviews] review granted: [Bug 83404] Remove dead code in SVGCSSParser : [Attachment 136120] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 23:58:56 PDT 2012

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 83404: Remove dead code in SVGCSSParser

Attachment 136120: Patch

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136120&action=review

Ah, just saw you posted a new patch, r=me for that as well, as it resolved my
issue :-)

> LayoutTests/svg/custom/script-tests/currentColor-on-color.js:13
> +rectElement.setAttribute("color", "currentColor");

This is not needed, is it?

> LayoutTests/svg/custom/script-tests/currentColor-on-color.js:19
r", "rgb(0, 128, 0)");

s/document.defaultView// (it's not need).

More information about the webkit-reviews mailing list