[webkit-reviews] review canceled: [Bug 83227] [chromium] wrong justification for arabic/persian page in cr-win : [Attachment 135946] patch w/ layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 19:29:26 PDT 2012

Xiaomei Ji <xji at chromium.org> has canceled Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 83227: [chromium] wrong justification for arabic/persian page in cr-win

Attachment 135946: patch w/ layout test

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
sorry that I found another 2 bugs in the CL.
1. the numSpaces should be counted within one TextRun, across m_runs so that
padding are evenly distributed inside TextRun.
2. sine shaping.m_justify is used not only in draw() but also in
advanceForItem(), I am keeping m_justify here with the value adjusted to
account for extra spacing.

related test is added.

More information about the webkit-reviews mailing list