[webkit-reviews] review granted: [Bug 83284] [chromium] Add support for Battery Status API : [Attachment 136101] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 6 17:10:16 PDT 2012
Adam Barth <abarth at webkit.org> has granted sadrul at chromium.org's request for
review:
Bug 83284: [chromium] Add support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=83284
Attachment 136101: Patch
https://bugs.webkit.org/attachment.cgi?id=136101&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136101&action=review
> Source/WebKit/chromium/src/BatteryClientImpl.cpp:54
> + m_controller->updateBatteryStatus(status);
status.release()
> Source/WebKit/chromium/src/BatteryClientImpl.cpp:77
> +void BatteryClientImpl::batteryControllerDestroyed()
> +{
> +}
Shouldn't we set m_controller = 0 ?
More information about the webkit-reviews
mailing list