[webkit-reviews] review granted: [Bug 83329] Enable webkit_unit_tests for commit queue and EWS while tracking failures : [Attachment 136065] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 14:37:59 PDT 2012


Adam Barth <abarth at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 83329: Enable webkit_unit_tests for commit queue and EWS while tracking
failures
https://bugs.webkit.org/show_bug.cgi?id=83329

Attachment 136065: Patch
https://bugs.webkit.org/attachment.cgi?id=136065&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136065&action=review


Ok.  Let's give this a try.  :)

> Tools/Scripts/webkitpy/tool/bot/layouttestresultsreader.py:73
> +	   unit_test_results = self._create_unit_test_results()
> +	   if layout_test_results and unit_test_results:

I would have just nested this inside the above if since there isn't much point
in calling _create_unit_test_results if layout_test_results is falsy.


More information about the webkit-reviews mailing list