[webkit-reviews] review granted: [Bug 83229] Virtualize createAnonymousBlockWithSameTypeAs and move to RenderBox : [Attachment 136040] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has granted Abhishek Arya
<inferno at chromium.org>'s request for review:
Bug 83229: Virtualize createAnonymousBlockWithSameTypeAs and move to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=83229

Attachment 136040: Patch
https://bugs.webkit.org/attachment.cgi?id=136040&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136040&action=review


> Source/WebCore/ChangeLog:9
> +	   table parts and in the future extend to more derived

Nit: "more derived" was like deeper class hierarchy in my first reading, I
would just re-arrange the wording: in the future extend to more classes derived
from RenderBox.

> Source/WebCore/ChangeLog:11
> +

Let's add a comment about why we did that: the current switch case situation
was going to be messy as we will need to mix cases that were very dependent on
the class so it made sense to add a virtual function.

> Source/WebCore/rendering/RenderBox.h:517
> +    virtual RenderBox* createAnonymousBoxWithSameTypeAs(const RenderObject*)
const

If you are exposing this function in the derived class, we may as well expose
this one. It's unfortunate that we have to but I see your point.