[webkit-reviews] review granted: [Bug 83055] Move (most of) Archive handling from FrameLoader to DocumentLoader : [Attachment 135690] Fix mhtml test failure
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 6 13:19:10 PDT 2012
Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 83055: Move (most of) Archive handling from FrameLoader to DocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=83055
Attachment 135690: Fix mhtml test failure
https://bugs.webkit.org/attachment.cgi?id=135690&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135690&action=review
This patch makes too much sense!
> Source/WebCore/loader/DocumentLoader.h:136
> void addAllArchiveResources(Archive*);
Can this be private now?
> Source/WebCore/loader/DocumentLoader.cpp:453
> + // Give archive machinery a crack at this document. If the MIME type is
not an archive type, it will return 0.
Give archive machinery -> Give the archive machinery
More information about the webkit-reviews
mailing list