[webkit-reviews] review denied: [Bug 83351] [chromium] Viewport is not filled when out of texture memory on mac : [Attachment 136050] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 83351: [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351

Attachment 136050: Patch
https://bugs.webkit.org/attachment.cgi?id=136050&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136050&action=review


> Source/WebCore/ChangeLog:22
> +	   In order to do this, we fix a bug in the occlusion tracker, that
> +	   allowed opaque() layers with skipsDraw to occlude, by sticking a
> +	   virtual skipsDraw() on the layer classes that the tiled layers
> +	   can override and return something useful with.

Forgive my change aversion, but I liked when skipsDraw was a property that was
localized internal to tiled layers and not public in a way that other parts of
the compositor needed to worry about.

Can visibleContentOpaqueRegion() just return the right thing for opaque()
layers, handling skipsDraw internally?

> Source/Platform/chromium/public/WebLayerTreeView.h:114
> +    // Sets the background color for the viewport.
> +    WEBKIT_EXPORT void setBackgroundColor(const WebCore::Color&);
> +

Since this is the platform interface, I think this needs to be WebColor.