[webkit-reviews] review denied: [Bug 83334] Provide Obj-C private API to simplify markup : [Attachment 135942] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 10:43:47 PDT 2012

Sam Weinig <sam at webkit.org> has denied Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 83334: Provide Obj-C private API to simplify markup

Attachment 135942: Patch

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135942&action=review

> Tools/TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:72
> +

We should test the different combinations this API allows, including non-nill
endNode, endNode before startNode, and endNode in a different document than
startNode.  I guess if should also make sure that startNode is in a document in

More information about the webkit-reviews mailing list