[webkit-reviews] review granted: [Bug 83366] Correct some LayoutUnit misuse in FilterEffectRenderer, RenderBlock, and RenderEmbeddedObject : [Attachment 136021] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Apr 6 10:17:58 PDT 2012
Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 83366: Correct some LayoutUnit misuse in FilterEffectRenderer, RenderBlock,
and RenderEmbeddedObject
https://bugs.webkit.org/show_bug.cgi?id=83366
Attachment 136021: Patch
https://bugs.webkit.org/attachment.cgi?id=136021&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136021&action=review
> Source/WebCore/rendering/RenderBlock.cpp:7475
> - return String::format("%p (%dx%d %dx%d)", floatingObject,
floatingObject->x(), floatingObject->y(), floatingObject->maxX(),
floatingObject->maxY());
> + return String::format("%p (%dx%d %dx%d)", floatingObject,
floatingObject->pixelSnappedX(), floatingObject->pixelSnappedY(),
floatingObject->pixelSnappedMaxX(), floatingObject->pixelSnappedMaxY());
Huh? Why does this method exist? :)
More information about the webkit-reviews
mailing list