[webkit-reviews] review canceled: [Bug 82476] Extra display logic for the media control panel element : [Attachment 136017] Fixed display bug and removed timer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 08:59:16 PDT 2012


Victor Carbune <vcarbune at adobe.com> has canceled Victor Carbune
<vcarbune at adobe.com>'s request for review:
Bug 82476: Extra display logic for the media control panel element
https://bugs.webkit.org/show_bug.cgi?id=82476

Attachment 136017: Fixed display bug and removed timer
https://bugs.webkit.org/attachment.cgi?id=136017&action=review

------- Additional Comments from Victor Carbune <vcarbune at adobe.com>
It seems that this method doesn't actually work, because dispatchEvent is
called only when a listener exists. I got tricked by the fact that the test
passes (because it has waitForEvent). The only way to do this is using a timer
- I will add a simpler patch just adding the extra variable.


More information about the webkit-reviews mailing list