[webkit-reviews] review requested: [Bug 83233] Add CodeGenerator support for sequence<> in callbacks : [Attachment 136025] patch_for_landing

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has asked  for review:
Bug 83233: Add CodeGenerator support for sequence<> in callbacks
https://bugs.webkit.org/show_bug.cgi?id=83233

Attachment 136025: patch_for_landing
https://bugs.webkit.org/attachment.cgi?id=136025&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>

> > Source/WebCore/bindings/js/JSMutationCallbackCustom.cpp:45
> > Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp:49
> Remove the function.

Done.
 
> > Source/WebCore/bindings/scripts/CodeGenerator.pm:457
> > +sub SendCallbackThisValue

> Nit: Maybe we want more descriptive method name. IsCallbackWithArrayType()?
Done 

> > Source/WebCore/bindings/scripts/CodeGenerator.pm:465
> > +
> 
> Nit: remove this line.
Done 
 
> > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2715
> > +		 push(@implContent, "@argsCheck\n") if scalar(@argsCheck) > 0;
> 
> Nit: Just 'if @argsCheck;' would work.
> > Source/WebCore/bindings/scripts/test/JS/JSTestCallback.cpp:174
Done