[webkit-reviews] review granted: [Bug 83152] [GTK] Separate image encoding from dataURL construction : [Attachment 135575] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 08:20:18 PDT 2012

Martin Robinson <mrobinson at webkit.org> has granted noel gordon
<noel.gordon at gmail.com>'s request for review:
Bug 83152: [GTK] Separate image encoding from dataURL construction

Attachment 135575: Patch

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135575&action=review

> Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp:70
> +    base64Encode(reinterpret_cast<const char*>(buffer.get()), bufferSize,

It seems unusual that we need this reinpterpret_cast here. Perhaps you could
try removing this before landing?

More information about the webkit-reviews mailing list