[webkit-reviews] review granted: [Bug 83365] Web Inspector: display frame details in popover on frame strip in Timeline panel : [Attachment 136019] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 83365: Web Inspector: display frame details in popover on frame strip in
Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=83365

Attachment 136019: Patch
https://bugs.webkit.org/attachment.cgi?id=136019&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136019&action=review


> Source/WebCore/inspector/front-end/TimelinePanel.js:372
> +	       frameStrip.__frame = frame;

Since you own this element, there is no point to use __ for the naming.

> Source/WebCore/inspector/front-end/TimelinePanel.js:758
> +	   if (anchor.classList.contains("timeline-frame-strip")) {

Please use hasStyleClass for consistency.