[webkit-reviews] review denied: [Bug 83360] [BlackBerry] Upstreaming BlackBerry-specific PluginView event handling : [Attachment 136001] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 05:57:01 PDT 2012

Rob Buis <rwlbuis at gmail.com> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 83360: [BlackBerry] Upstreaming BlackBerry-specific PluginView event

Attachment 136001: Patch

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=136001&action=review

Still some stuff to clear up.

> Source/WebCore/plugins/PluginView.cpp:186
> +#endif

How about like this:
if (!m_plugin
       || m_isWindowed // On BB windowed plugins want to get events.

> Source/WebCore/plugins/PluginView.cpp:202
> +    else if (event->type() == eventNames().DOMFocusOutEvent)

Any difference between DOMFocusOutEvent and focusoutEvent below?

More information about the webkit-reviews mailing list