[webkit-reviews] review granted: [Bug 83353] [Chromium] Web Inspector: getEventListeners(window) crashes on NTP : [Attachment 136002] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 6 04:59:37 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 83353: [Chromium] Web Inspector: getEventListeners(window) crashes on NTP
https://bugs.webkit.org/show_bug.cgi?id=83353

Attachment 136002: Patch
https://bugs.webkit.org/attachment.cgi?id=136002&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=136002&action=review


> Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:222
> +    if (!value->IsObject() || !V8Node::HasInstance(value->ToObject()))

HasInstance receives value, no need to cast.


More information about the webkit-reviews mailing list