[webkit-reviews] review denied: [Bug 80200] Add transfer map argument to Intent constructor : [Attachment 135932] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 80200: Add transfer map argument to Intent constructor
https://bugs.webkit.org/show_bug.cgi?id=80200

Attachment 135932: Patch
https://bugs.webkit.org/attachment.cgi?id=135932&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135932&action=review


> Source/WebCore/Modules/intents/Intent.cpp:36
> +#include "ScriptExecutionContext.h"

Remove this

> Source/WebCore/Modules/intents/Intent.cpp:41
> +PassRefPtr<Intent> Intent::create(ScriptExecutionContext* context, const
String& action, const String& type, PassRefPtr<SerializedScriptValue> data,
ExceptionCode& ec)

Why do you need ScriptExecutionContext here? It seems it is not used.

> Source/WebCore/Modules/intents/Intent.cpp:55
> +PassRefPtr<Intent> Intent::create(ScriptExecutionContext* context, const
String& action, const String& type, PassRefPtr<SerializedScriptValue> data,
const MessagePortArray& ports, ExceptionCode& ec)

Ditto.

> Source/WebCore/Modules/intents/Intent.h:44
> +class ScriptExecutionContext;

Ditto.

> Source/WebCore/Modules/intents/Intent.h:52
> +    static PassRefPtr<Intent> create(ScriptExecutionContext*, const String&
action, const String& type, PassRefPtr<SerializedScriptValue> data,
ExceptionCode&);
> +    static PassRefPtr<Intent> create(ScriptExecutionContext*, const String&
action, const String& type, PassRefPtr<SerializedScriptValue> data, const
MessagePortArray& ports, ExceptionCode&);

Ditto.

> Source/WebCore/Modules/intents/Intent.idl:30
> +	 CallWith=ScriptExecutionContext,

Remove this.