[webkit-reviews] review requested: [Bug 83351] [chromium] Viewport is not filled when out of texture memory on mac : [Attachment 135981] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 83351: [chromium] Viewport is not filled when out of texture memory on mac
https://bugs.webkit.org/show_bug.cgi?id=83351

Attachment 135981: Patch
https://bugs.webkit.org/attachment.cgi?id=135981&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
Here's a CL to make sure we draw something opaque in every pixel in the
viewport without special-casing drawing of the NCCH.

I renamed "backgroundCoversViewport" since that is not what it actually means.
I propose the name "rootContentLayer" instead,
to say that the layer is the parent of all content in the tree, and that its
background color should be used to fill the
background of the viewport.

We use the occlusion tracker to figure out what pixels we are seeing through
the viewport with, and we add "gutter quads" to
cover those pixels up with the NCCH background color. I tested this with
acko.net, by setting the memory limits very low, and
it seems well. Am running a mac try job to try and verify that the
rubberbanding works.