[webkit-reviews] review granted: [Bug 83255] [chromium] REGRESSION: Refreshed autofill popup renders garbage : [Attachment 135798] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 83255: [chromium] REGRESSION: Refreshed autofill popup renders garbage
https://bugs.webkit.org/show_bug.cgi?id=83255

Attachment 135798: Patch
https://bugs.webkit.org/attachment.cgi?id=135798&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135798&action=review


> Source/WebCore/ChangeLog:8
> +
> +	   No new tests, as the popup appearance is not testable in WebKit.

It would be nice if you explain what was wrong and how do you fix it in
ChangeLog.

> Source/WebCore/platform/chromium/PopupContainer.cpp:202
> +    // In screen coordinates.
>      return widgetRect;

Renaming widgetRect to widgetRectInScreen might be better.

> Source/WebCore/platform/chromium/PopupContainer.cpp:418
> +    // In window coordinates.
>      IntPoint location =
m_frameView->contentsToWindow(targetControlRect.location());

ditto.	locationInWindow

> Source/WebCore/platform/chromium/PopupContainer.cpp:424
> +    // In screen coordinates.
>      IntRect widgetRect =
layoutAndCalculateWidgetRect(targetControlRect.height(), location);

ditto. widgetRectInScreen