[webkit-reviews] review granted: [Bug 83340] [BlackBerry] Enable vibration for the BlackBerry port : [Attachment 135954] Patch to enable vibration

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has granted George Staikos <staikos at kde.org>'s
request for review:
Bug 83340: [BlackBerry] Enable vibration for the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=83340

Attachment 135954: Patch to enable vibration
https://bugs.webkit.org/attachment.cgi?id=135954&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135954&action=review


Looks good.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:30
> +}

May want to keep this in the header inline for now.

> Source/WebKit/blackberry/WebCoreSupport/VibrationClientBlackBerry.cpp:38
> +{

Ditto.

> Source/cmake/OptionsBlackBerry.cmake:178
> +WEBKIT_FEATURE(ENABLE_VIBRATION "Enable vibration support" DEFAULT ON)

Any change needed in build-webkit? cmakeconfig.cmake? Usually they go
hand-in-hand.