[webkit-reviews] review denied: [Bug 83302] IndexedDB: Refactor cursor iteration to remove duplicate code : [Attachment 135896] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Apr 5 16:53:33 PDT 2012
Tony Chang <tony at chromium.org> has denied Alec Flett <alecflett at chromium.org>'s
request for review:
Bug 83302: IndexedDB: Refactor cursor iteration to remove duplicate code
https://bugs.webkit.org/show_bug.cgi?id=83302
Attachment 135896: Patch
https://bugs.webkit.org/attachment.cgi?id=135896&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135896&action=review
> Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp:1034
> + return continueFunction(0, true);
Please declare and use an enum rather than a bool. There are other examples of
this in the code base.
More information about the webkit-reviews
mailing list