[webkit-reviews] review requested: [Bug 73083] Fix the Frame Leak Attack : [Attachment 135923] Alternate patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 16:00:43 PDT 2012


Thomas Sepez <tsepez at chromium.org> has asked  for review:
Bug 73083: Fix the Frame Leak Attack
https://bugs.webkit.org/show_bug.cgi?id=73083

Attachment 135923: Alternate patch
https://bugs.webkit.org/attachment.cgi?id=135923&action=review

------- Additional Comments from Thomas Sepez <tsepez at chromium.org>
Alternate version of patch.  Moves the ancestor check implementation into
Document to be more consistent with Adam's recent changes.  Resolve the
Anchor/Fragment naming issue in favor of "fragment" to maintain consistency
with frameview's notion of scrolltofragment (which takes URLS) and
scrollToAnchor (which takes a string naming the anchor).  The operations in
frameloader all manipulate URLS, so use "fragment".  Clean up some comment to
keep consistent where there's an URL involved.


More information about the webkit-reviews mailing list