[webkit-reviews] review granted: [Bug 83214] [Chromium] moving a cursor on a misspelled word should not remove a misspelled underline : [Attachment 135691] A patch v0

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 83214: [Chromium] moving a cursor on a misspelled word should not remove a
misspelled underline
https://bugs.webkit.org/show_bug.cgi?id=83214

Attachment 135691: A patch v0
https://bugs.webkit.org/attachment.cgi?id=135691&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135691&action=review


>>> Source/WebCore/editing/Editor.cpp:2931
>>> +#else
>> 
>> Does this need to be guarded inside Chromium at all? Doesn't other port that
implements async spell checking want this fix as well?
> 
> Unfortunately, it loses compatibility with AppKit on Snow Leopard. Even
though AppKit of Snow Leopard can spellcheck text in the background when we
paste text, it deletes misspelling markers when we move a cursor.

Interesting. It seems acceptable to land this patch as is but we should figure
out a better way of abstracting these port-specific behaviors.
Maybe we want some client callback here?