[webkit-reviews] review granted: [Bug 83294] perf-o-matic should include unit in runs JSON responses : [Attachment 135856] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 83294: perf-o-matic should include unit in runs JSON responses
https://bugs.webkit.org/show_bug.cgi?id=83294

Attachment 135856: Patch
https://bugs.webkit.org/attachment.cgi?id=135856&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135856&action=review


> Websites/webkit-perf.appspot.com/models.py:452
> +	   return '{"test_runs": [%s], "averages": {%s}, "min": %s, "max": %s,
"unit": %s, "date_range": null, "stat": "ok"}' % (self.json_runs,
> +	       self.json_averages, str(self.json_min) if self.json_min else
'null', str(self.json_max) if self.json_max else 'null',

Nit: You might want to start naming the strings. E.g., %(test_runs)s ..
%(averages)s .. etc.  That might make it a bit easier to match up the string
substitutions.