[webkit-reviews] review granted: [Bug 82970] Move correction panel related functions from EditorClient into separated AlternativeTextClient class. : [Attachment 135816] Fixing build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 10:40:06 PDT 2012


Enrica Casucci <enrica at apple.com> has granted Jia Pu <jpu at apple.com>'s request
for review:
Bug 82970: Move correction panel related functions from EditorClient into
separated AlternativeTextClient class.
https://bugs.webkit.org/show_bug.cgi?id=82970

Attachment 135816: Fixing build.
https://bugs.webkit.org/attachment.cgi?id=135816&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=135816&action=review


Looks good to me. Please add the null check on the m_frame per my comment above
before landing.

> Source/WebCore/editing/AlternativeTextController.cpp:473
> +    return m_frame->page() ? m_frame->page()->alternativeTextClient() : 0;

Should you check also that m_frame is not null?


More information about the webkit-reviews mailing list