[webkit-reviews] review granted: [Bug 83240] Provide a separate editing command to cleanup of redundant markup : [Attachment 135745] Patch2

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 83240: Provide a separate editing command to cleanup of redundant markup
https://bugs.webkit.org/show_bug.cgi?id=83240

Attachment 135745: Patch2
https://bugs.webkit.org/attachment.cgi?id=135745&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135745&action=review


Please fix the gtk build before you land. Also, you probably need to modify
EditorAllInOne.cpp for Windows.

> Source/WebCore/editing/ReplaceSelectionCommand.cpp:1023
> -	   removeRedundantMarkup(insertedNodes);
> +	   applyCommandToComposite(SimplifyMarkupCommand::create(document(),
insertedNodes.firstNodeInserted(), insertedNodes.pastLastLeaf()));

You should add simplifyMarkup() to CompositeEditCommand.

> Source/WebCore/editing/SimplifyMarkupCommand.cpp:2
> + * Copyright (C) 2005, 2006 Apple Computer, Inc.  All rights reserved.

Maybe you should add 2011 here?