[webkit-reviews] review granted: [Bug 83176] gtk_unittest.GtkPortTest.test_get_crash_log failing on windows : [Attachment 135771] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 10:26:06 PDT 2012


Tony Chang <tony at chromium.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 83176: gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
https://bugs.webkit.org/show_bug.cgi?id=83176

Attachment 135771: Patch
https://bugs.webkit.org/attachment.cgi?id=135771&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
If GtkPort._get_crash_log used FileSystem.join and you used MockFileSystem in
the test, you would always get / when running the test since MockFileSystem
always uses / as the separator.

This seems fine too.


More information about the webkit-reviews mailing list