[webkit-reviews] review requested: [Bug 83030] [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks() : [Attachment 135814] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 06:48:24 PDT 2012


Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 83030: [EFL] DRT should support LayoutTestController's
dumpFrameLoadCallbacks()
https://bugs.webkit.org/show_bug.cgi?id=83030

Attachment 135814: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=135814&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Reuse existing signals as suggested and remove the one with enumeration.

Please note that I had to emit the "load,finished" signal from
dispatchDidFailLoad() / dispatchDidFinishLoad(), instead of
postProgressFinishedNotification().
Otherwise, I miss a "didFinishLoadForFrame" in some tests.


More information about the webkit-reviews mailing list