[webkit-reviews] review denied: [Bug 83137] [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC : [Attachment 135768] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Apr 5 00:52:25 PDT 2012


Kentaro Hara <haraken at chromium.org> has denied ChangSeok Oh
<kevin.cs.oh at gmail.com>'s request for review:
Bug 83137: [GTK][DRT] Fail fast/filesystem/flags-passing.html on JSC
https://bugs.webkit.org/show_bug.cgi?id=83137

Attachment 135768: Patch
https://bugs.webkit.org/attachment.cgi?id=135768&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=135768&action=review


> LayoutTests/fast/filesystem/script-tests/flags-passing.js:27
> +	   window[testsList[testCounter++]]();

The change looks OK, but we can simplify the code more, like this:

var testsList = [runObjectTest, cleanupAndRunNext, ...];  // An array of
functions (not function names)

... else {
  (testsList[testCounter++])();
}


More information about the webkit-reviews mailing list