[webkit-reviews] review requested: [Bug 74135] Auto width is not working for Regions : [Attachment 135765] Patch to apply containing block available width for region, whenever width is not specified.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 4 23:48:37 PDT 2012


Swapna <spottabathini at innominds.com> has asked	for review:
Bug 74135: Auto width is not working for Regions
https://bugs.webkit.org/show_bug.cgi?id=74135

Attachment 135765: Patch to apply containing block available width for region,
whenever width is not specified.
https://bugs.webkit.org/attachment.cgi?id=135765&action=review

------- Additional Comments from Swapna <spottabathini at innominds.com>
Hi,
As per my analysis, as region is a replaced element its width is calculated in
function RenderReplaced::computeReplacedLogicalWidth. In this function if
region width is not specifed in style, it will check for intrinsic width. In
present case region width is not specified and intrinsicWidth=0. This
intrinsicWidth=0 is applied to region.
By this reason(regionWidth=0), in RenderBlock::LineBreaker::nextLineBreak
function, while checking for available width for every encounter of space(" ")
it is getting availableWidth=0, then it is doing line break. This is how it is
showing single line content in multiple lines.
Whenever region width is not specified , it should take available width in its
containing block. Did the same in the patch to resolve issue.(see the patch)

Can any one please review this patch.


More information about the webkit-reviews mailing list